Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document --homefile behaviour #1063

Open
shilorigins opened this issue Feb 27, 2024 · 0 comments
Open

Document --homefile behaviour #1063

shilorigins opened this issue Feb 27, 2024 · 0 comments

Comments

@shilorigins
Copy link
Contributor

What's the problem this feature will solve?

Setting --homefile from the CLI or the home_file parameter in PyDMApplication loads the chosen file into a display during startup. Clicking the home button in the navigation bar then simply shows this pre-loaded display.

This behaviour has significant performance impacts (~35% of LCLSHome's startup time is dedicated to loading the homefile) and can be unintuitive. For example, clicking the home button has no effect if the home display is already being shown, which can be confusing if the home display is stateful. Additionally, if the homefile is the same as the file being launched, two instances of the same display are created.

Describe the solution you'd like

I'd like this behaviour to be documented so that developers are aware of the potential performance impacts and actual behaviour of PyDM's built-in home button.

Additional context

@shilorigins shilorigins changed the title Document --homefile performance impacts and behaviour Document --homefile behaviour Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant