Replies: 2 comments
-
Fine with me. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Honestly I don't think this change is worth it. The overall setup seems to work fine right now. However, it might be nice to enable separate issue trackers 😉 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Right now, there are a number of seperate feature crates in the main
slog-rs
organization:Many of these do not have their own issue tracker, and they often seem to fall behind the main crate 😦
It might make sense to either:
workspace
in the main repositoryI would note that some of these crates are effectively official (and very stable). Keeping them as separate repositories doesn't really add much to the main crate 😉
Things to merge
Crates I propose integrating into the main repo, as part of the main workspace:
slog-term
slog-json
slog-async
slog-stdlog
These crates are essential to most
slog
users and the ecosystem as a whole. It makes sense to provide the same level of support as we do in the main repo.Disadvantages:
Advantages:
slog
breaks one of these crates, we will know right awaycargo check --workspace
and we will get a message (and GH actions will fail)slog-term
, then filing it on the main repo.Honestly, I think it's worth it so that we can provide first-class support for these crates :)
Note that user-level dependencies would still be separate. Adding
slog
as a dependency wouldn't automatically addslog-term
orslog-json
.Things to keep seperate
Crates I propose keeping separate (for now):
slog-scope
slog-journald
slog-syslog
slog-bunyan
For all of these, we should enable github issues, so people have a proper place to put bugs 😉
I think (1) should be separate (probably permanently) because it's discouraged.
Crates 2-4 seem like more niche logging formats. Maybe we could move them in eventually........
Beta Was this translation helpful? Give feedback.
All reactions