Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceMonitor for Prometheus-Operator #178

Closed
genofire opened this issue Apr 9, 2024 · 1 comment
Closed

ServiceMonitor for Prometheus-Operator #178

genofire opened this issue Apr 9, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request needs triage Waiting for discussion / prioritization by team

Comments

@genofire
Copy link

genofire commented Apr 9, 2024

What would you like to be added

option to enable metrics
and deploy if wanted an servicemonitor

with configurable labels

Why this is needed

To get Metrics on an Kubernetes Way:

since 0.26.0 in support:
smallstep/certificates#1669

@genofire genofire added enhancement New feature or request needs triage Waiting for discussion / prioritization by team labels Apr 9, 2024
@dopey
Copy link
Contributor

dopey commented Apr 10, 2024

Hey @genofire 👋. Thanks for opening the issue!

The feature you're referring to in step-ca (the addition of some prometheus style metrics) is undocumented because we are already planning to change the interface. As such, we do not want to add configuration to the helm-charts for integrating against an interface that we know is unstable. Similarly I would caution against integrating or relying too heavily on the metrics currently being output by step-ca.

@dopey dopey closed this as completed Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

No branches or pull requests

2 participants