Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorize the project structure #19

Open
pvk-developer opened this issue Aug 18, 2019 · 0 comments
Open

Refactorize the project structure #19

pvk-developer opened this issue Aug 18, 2019 · 0 comments

Comments

@pvk-developer
Copy link

The project structure at the moment looks like this:

├── action.py
├── actions
│   ├── hello.py
│   └── __init__.py
├── api.py
├── application.py
├── cli.py
├── __init__.py
├── logging_utils.py
├── middleware.py
├── resource.py
├── resources
│   ├── __init__.py
│   └── misc.py
├── runnable.py
└── utils.py

The file action.py and resource.py both contain the BaseAction and BaseResource which are supposed to be inherit from.

I would like to suggest to change action.py and resource.py into base.py inside the folders actions and resources. Also, the cli.py we should rename it to __main__.py to follow the new standards.

.
├── actions
│   ├── base.py
│   ├── hello.py
│   └── __init__.py
├── api.py
├── application.py
├── __init__.py
├── logging_utils.py
├── __main__.py
├── middleware.py
├── resources
│   ├── base.py
│   ├── __init__.py
│   └── misc.py
├── runnable.py
└── utils.py

Also, here I'm open for suggestions, the utils.py file and logging_utils.py can create a module named utils or be unified in the same file ?

@pvk-developer pvk-developer changed the title Refactor the project structure Refactorize the project structure Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant