-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a mechanism to declare support for specific capabilities #136
Comments
Modularizing a SMART on FHIR implementation and formally describing it via the core capability concepts makes sense. This will provide an achievement-style staged road map for future implementations where partial implementations are not seen as failure. Also, sets the stage for extending the standard in a discoverable way. Two observations here:
|
Thanks @nschwertner. For (1), is there a different place you'd naturally put this info? For (2), I think |
Cool. I didn't see the refresh token in the core list description file which made me wonder (db07b55) Regarding (1), I don't see any better place to put it in the current definition of the CapabilitiesStatement. Just saying that |
The core capabilities seem to refer to the various ways and contexts in which the app can be launched (?correct) What is the thinking around specific scopes (read/write access to specific resources) and resource content profiles? |
You're correct, @davidhay25. Overall, there are a great number of combinations of these granular permissions, and
I might rather fall back to the server's stated capabilities (via standard FHIR properties) with the expectation that if a server can support reading or writing a particular resource, then the relevant scopes should also be supported. It is not a perfect assumption, but I suspect it is a lot of bang for the buck. |
That would seem to be a pragmatic way for the client to understand a
servers capabilities. So SMART won't itself define (or refer to) a profile
- rather leave that to the individual client/server interaction...
…On Wed, Apr 12, 2017 at 1:21 PM, Josh Mandel ***@***.***> wrote:
You're correct, @davidhay25 <https://github.com/davidhay25>.
Overall, there are a great number of combinations of these granular
permissions, and
1. I'm not sure we can get the details perfectly correct "in general".
2. I'm not in love with our permission model, and while I don't
propose to revise it here, neither do I want to invest too much more in it.
I might rather fall back to the server's stated capabilities (via standard
FHIR properties) with the expectation that if a server can support reading
or writing a particular resource, then the relevant scopes should also be
supported. It is not a perfect assumption, but I suspect it is a lot of
bang for the buck.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#136 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFYPFE9vDvkhE1G1xCqBOBm6ILMufuBVks5rvCcNgaJpZM4M5Onz>
.
|
for these capabilities:
Are these intended to also cover if these contexts are returned when just "launch" scope is requested (in the ehr launched scenario) and not just the standalone? Or only intended to cover the standalone launch scenarios that would use launch/patient and launch/encounter? |
The intention would be that these context parameters are available for both EHR Launch and Standalone Launch @daliboz; would you propose separating these out? |
I think we should clarify the text to indicate it's not just applicable to launch/patient and launch/encounter if that's the direction this goes. As to separating them: |
I think that we should consider grouping the declaration of support for the launch-context capabilities under or within the launch modes. context-banner and perhaps context-style don't really make sense to be used for launch-standalone. We primarily only support contextual launch parameters from EHR/embedded launches. Standalone launches with contextual launch parameters can only be supported if the EHR provides a selector UI to the authorizing user. The value in a patient/encounter selector is to enable dynamic OAuth scopes. E.g. A provider only wants to enable an app to access data on her behalf for a specific patient's encounter. We don't currently support these types of dynamic scopes, so we, therefore, also don't have this selector UI. Isaac |
Referring to: http://www.hl7.org/fhir/smart-app-launch/conformance/core-set/ Making the context-standalone-patient and context-standalone-encounter part of the core capabilities of a SMART server require that the server implement a "patient/encounter picker". This UI element seems above and beyond the basic authnz functionality provided by the rest of the minimal, "core" functionality defined in Core Capabilities. I think that context-standalone-patient and context-standalone-encounter should be removed from Core Capabilities. |
The SMART on FHIR specification leaves open the question of which capabilities a given EHR server needs to support. To help drive more consistent support, we can take two steps:
Draft definitions at:
https://github.com/smart-on-fhir/smart-on-fhir.github.io/blob/into-hl7/conformance/index.md
https://github.com/smart-on-fhir/smart-on-fhir.github.io/blob/into-hl7/conformance/core-set.md
The text was updated successfully, but these errors were encountered: