Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Parser - Reserved C++ keywords are missing #287

Open
joeljfischer opened this issue Oct 30, 2020 · 0 comments
Open

RPC Parser - Reserved C++ keywords are missing #287

joeljfischer opened this issue Oct 30, 2020 · 0 comments
Labels

Comments

@joeljfischer
Copy link
Contributor

C++ keywords are not being reserved by the RPC spec parser making incorrect generated code appear in at least one case for iOS code:

/**
 * @param template - template
 * @return A SDLTemplateConfiguration object
 */
- (instancetype)initWithTemplate:(NSString *)template;

/**
 * @param template - template
 * @param dayColorScheme - dayColorScheme
 * @param nightColorScheme - nightColorScheme
 * @return A SDLTemplateConfiguration object
 */
- (instancetype)initWithTemplate:(NSString *)template dayColorScheme:(nullable SDLTemplateColorScheme *)dayColorScheme nightColorScheme:(nullable SDLTemplateColorScheme *)nightColorScheme;

Here template is reserved for C++ and therefore this code will not compile for Obj-C++ projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant