Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio manager should suspend transcoding if app using secondary transports is backgrounded #1598

Open
NicoleYarroch opened this issue Mar 24, 2020 · 1 comment
Open

Audio manager should suspend transcoding if app using secondary transports is backgrounded #1598

NicoleYarroch opened this issue Mar 24, 2020 · 1 comment
Labels
best practice Not a defect but something that should be improved anyway manager-streaming-audio Relating to the manager layer - audio streaming

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

The SDLStreamingAudioLifecycleManager should suspend transcoding if the app on the device using is backgrounded while using a TCP secondary transport, just like the video manager does. Since the TCP socket is closed when the app on the device is backgrounded, the manager is doing useless work.

Note: Audio should still stream if audio is being streamed over the primary transport even if the app on the device is backgrounded.

Reproduction Steps
  1. Connect a video streaming app using secondary transports to SYNC 4.
  2. Background the app on the device.
Expected Behavior

Audio transcoding should stop as the secondary transport has been closed.

Observed Behavior

Audio transcoding continues even though the data can not be sent.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.5
  • Testing Against: SYNC 4
@NicoleYarroch NicoleYarroch added best practice Not a defect but something that should be improved anyway manager-streaming-audio Relating to the manager layer - audio streaming labels Mar 24, 2020
@NicoleYarroch
Copy link
Contributor Author

This only appears to be an issue if the TCP socket fails to connect (i.e. the system wifi is down or an error occurred during connection).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway manager-streaming-audio Relating to the manager layer - audio streaming
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

bugfix/issue-1598-audio-manager-suspend smartdevicelink/sdl_ios
2 participants
@NicoleYarroch @jshivabeharry