Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git bindings library #65

Open
stellarhoof opened this issue Jan 25, 2019 · 0 comments
Open

Use git bindings library #65

stellarhoof opened this issue Jan 25, 2019 · 0 comments

Comments

@stellarhoof
Copy link
Member

stellarhoof commented Jan 25, 2019

Right now autoFix calls the git cmdline as an external process directly,
which is a very ad-hoc approach. More robust would be to use js bindings
to libgit (https://github.com/nodegit/nodegit).

Another advantage of using a library for interacting with git is that we can
mock the library, whereas right now it's very hard to test current functionality.
We'd potentially have to mock the child_process node module itself and
parse the command to verify the right processes with the right arguments
are being called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant