Unhandled invalid file names

[KennyDeardorff]

Description

Somehow, a folder was created in Smartsheet with a carriage return in the folder name. When the backup script tried to create this folder, it threw a CreateFileSystemItemException and stopped scanning for files/folders and moved on to the next user.

Desired behavior

I would like the script to be able to handle this kind of error so that as many sheets are backed up as possible. I think the best solution would be to remove the invalid characters from the file/folder name and continue recursing. Second best option might be to skip that file/folder, but continue with the next sibling/parent folder.

Details

Script version: 1.6.2
Downloading to a Windows file system
continueOnError=true

Call Stack

Note the line break in Folder With<newline>Newline In Name

com.smartsheet.exceptions.CreateFileSystemItemException: C:\Temp\smartsheet-backup\smartsheet-backup\2020-06-11_15_12_57\[[email protected]]\Workspaces\Folder 1\Folder 2\Folder 3\Folder With 
Newline In Name could not be created
	at com.smartsheet.tools.SmartsheetBackupService.createNewFolderQuietly(SmartsheetBackupService.java:322)
	at com.smartsheet.tools.SmartsheetBackupService.createNewFolder(SmartsheetBackupService.java:307)
	at com.smartsheet.tools.SmartsheetBackupService.createFoldersRecursively(SmartsheetBackupService.java:337)
	at com.smartsheet.tools.SmartsheetBackupService.createFoldersRecursively(SmartsheetBackupService.java:346)
	at com.smartsheet.tools.SmartsheetBackupService.createFoldersRecursively(SmartsheetBackupService.java:346)
	at com.smartsheet.tools.SmartsheetBackupService.createFoldersRecursively(SmartsheetBackupService.java:346)
	at com.smartsheet.tools.SmartsheetBackupService.backupTo(SmartsheetBackupService.java:197)
	at com.smartsheet.tools.SmartsheetBackupService.assumeUserAndBackup(SmartsheetBackupService.java:160)
	at com.smartsheet.tools.SmartsheetBackupService.backupOrgTo(SmartsheetBackupService.java:122)
	at com.smartsheet.tools.SmartsheetBackupTool.main(SmartsheetBackupTool.java:107)

[KennyDeardorff]

It looks like the code is already trying to scrub the file/folder names, but it just wasn't expecting a carriage return/line feed:

backup-java/src/main/java/com/smartsheet/tools/SheetSaver.java

Lines 211 to 214 in e25f95b

	public static String scrubName(String fileName) {
	return fileName.replaceAll("[\\\\/:\\*?\"<>|]+", "_");
	}