Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.6 release failed to build with go 1.21.0 #15

Closed
chenrui333 opened this issue Aug 13, 2023 · 5 comments
Closed

0.1.6 release failed to build with go 1.21.0 #15

chenrui333 opened this issue Aug 13, 2023 · 5 comments

Comments

@chenrui333
Copy link

Looks like 0.1.6 release does not build with go1.21.0, see the error log as below:

# github.com/anacrolix/go-libutp
/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/callbacks.go:16:10: cannot define new methods on non-local type *C.utp_callback_arguments
/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/callbacks.go:24:10: cannot define new methods on non-local type *C.utp_callback_arguments
/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/callbacks.go:28:10: cannot define new methods on non-local type *C.utp_callback_arguments
/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/callbacks.go:32:10: cannot define new methods on non-local type *C.utp_callback_arguments
/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/callbacks.go:36:10: cannot define new methods on non-local type *C.utp_callback_arguments
/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/utp.go:29:12: cannot define new methods on non-local type *C.utp_context
/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/utp.go:40:12: cannot define new methods on non-local type *C.utp_context

relates to Homebrew/homebrew-core#134468

@chenrui333 chenrui333 changed the title Failed to build with go 1.21.0 0.1.6 release failed to build with go 1.21.0 Aug 13, 2023
@anacrolix
Copy link

There's a fix if you run go get github.com/anacrolix/[email protected]. It might also have been pulled into some upstream modules like anacrolix/torrent.

@chenrui333
Copy link
Author

There's a fix if you run go get github.com/anacrolix/[email protected]. It might also have been pulled into some upstream modules like anacrolix/torrent.

should this dependency update be incorporated into the go.mod?

@anacrolix
Copy link

Running that command should update the // indirect dependency in go.mod, assuming you are not using go-libutp directly from your module.

@FIGBERT
Copy link
Member

FIGBERT commented Aug 22, 2023

Also going to use this issue to briefly apologize for my general inactivity here. I hope to get back to working on this in my spare time eventually, I really like the project. Just very busy as of late :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants