From f5f767eb7fc79b53a022736d3581fded518d32ce Mon Sep 17 00:00:00 2001 From: Roozbeh Sharifnasab Date: Mon, 14 Oct 2024 18:45:43 +0330 Subject: [PATCH 1/3] feat: remove sensitive info from auth.go --- internal/api/auth.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/internal/api/auth.go b/internal/api/auth.go index 3bd7579..340437e 100644 --- a/internal/api/auth.go +++ b/internal/api/auth.go @@ -48,9 +48,6 @@ func (a API) Authv1(c *fiber.Ctx) error { auth := a.Authenticator(vendor) span.SetAttributes( - attribute.String("token", request.Token), - attribute.String("username", request.Username), - attribute.String("password", request.Password), attribute.String("authenticator", auth.GetCompany()), ) @@ -115,9 +112,6 @@ func (a API) Authv2(c *fiber.Ctx) error { auth := a.Authenticator(vendor) span.SetAttributes( - attribute.String("token", request.Token), - attribute.String("username", request.Username), - attribute.String("password", request.Password), attribute.String("authenticator", auth.GetCompany()), ) From f7ec4e588dbfd0845f4027493d0ed6cd94ede7e6 Mon Sep 17 00:00:00 2001 From: Roozbeh Sharifnasab Date: Mon, 14 Oct 2024 18:45:52 +0330 Subject: [PATCH 2/3] feat: remove sensitive info from acl.go --- internal/api/acl.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/internal/api/acl.go b/internal/api/acl.go index 222bc17..9f7f22c 100644 --- a/internal/api/acl.go +++ b/internal/api/acl.go @@ -55,9 +55,6 @@ func (a API) ACLv1(c *fiber.Ctx) error { span.SetAttributes( attribute.String("access", request.Access.String()), attribute.String("topic", request.Topic), - attribute.String("token", request.Token), - attribute.String("username", request.Username), - attribute.String("password", request.Password), attribute.String("authenticator", auth.GetCompany()), ) @@ -152,9 +149,6 @@ func (a API) ACLv2(c *fiber.Ctx) error { span.SetAttributes( attribute.String("access", request.Action), attribute.String("topic", request.Topic), - attribute.String("token", request.Token), - attribute.String("username", request.Username), - attribute.String("password", request.Password), attribute.String("authenticator", auth.GetCompany()), ) From 95cdbe963ba4b0b2d25bfca9168ab5869c3b998d Mon Sep 17 00:00:00 2001 From: Roozbeh Sharifnasab Date: Mon, 14 Oct 2024 18:49:19 +0330 Subject: [PATCH 3/3] style: set attribute in one line --- internal/api/auth.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/internal/api/auth.go b/internal/api/auth.go index 340437e..d76e7e7 100644 --- a/internal/api/auth.go +++ b/internal/api/auth.go @@ -47,9 +47,7 @@ func (a API) Authv1(c *fiber.Ctx) error { auth := a.Authenticator(vendor) - span.SetAttributes( - attribute.String("authenticator", auth.GetCompany()), - ) + span.SetAttributes(attribute.String("authenticator", auth.GetCompany())) err := auth.Auth(token) if err != nil { @@ -111,9 +109,7 @@ func (a API) Authv2(c *fiber.Ctx) error { auth := a.Authenticator(vendor) - span.SetAttributes( - attribute.String("authenticator", auth.GetCompany()), - ) + span.SetAttributes(attribute.String("authenticator", auth.GetCompany())) err := auth.Auth(token) if err != nil {