Refactor delegation mechanics and make as a core feature

[bonustrack]

We need to specs how to move to delegation as core feature, this will require changes on:

snapshot-hub
snapshot-score
snapshot-strategies
snapshot

[ChaituVR]

Few questions to find out the specs:

• Can the delegator take back their voting power when they vote? like in delegation strategy
• While setting the delegation, will the user be able to set it on the entire space or on a single strategy like network field?

[ChaituVR]

• Changes in UI:
  • On top of all strategies add a select menu for the delegation with the following options:
    • None
    • Only delegated Voting power
    • Delegated + Own Voting power
  • Add a checkbox "Delegator can take back their voting power when they vote"
  • While creating a proposal, on the new vote and when calculating the VP before the vote, send the following params along with the network param:
    "delegation": { type: 'only-delegated', delegatorRevert: true, space: 'balancer.eth' }
    Value can also be none only-delegated delegated-and-self
  • Use VP and vp_by_strategy from the votes query, don't calculate voting power on UI,
  • Show Current results result from scores and scores_by_strategy from proposal query
  • If the proposal block is from the future, show a message "Snapshot block is from future than proposal start, so voting power may be outdated, voting power will be updated once the proposal is closed"
• Changes in hub:
  • On Vote, calculate the voting power and save the voting power, if the block is in the future set scores_state: "pending" else scores_state: "finished"
  • If the proposal has delegatorRevert: true, after getting the voting power, check if the delegations field exists, find the top delegate of the voter (example if A -> B -> C, If A vote now and C already voted and not B, C will be the top delegate, if C didn't vote and B voted, B will be the top delegate) Reduce the voting power of current voter from the top delegate score
  • On the Proposal end, if scores_state: "pending" calculate the score with all voters, and store the voting power
• Changes in score API and strategies
  • Receive delegation param from the input
  • inside getScoresDirect if delegation.type !== 'none' get the delegations of all the voters (recurevely), based on the type, calculate the voting power
  • if delegatorRevert: true then reduce the voting power from the above level delegate VP, recursively

[bonustrack]

@ChaituVR Core delegation should work only with "Delegated + Own Voting power" we shouldn't provide option to work with just Delegated vp, not sure who would need that? Also we shouldn't allow "Delegator can take back their voting power when they vote" this is exactly what blocking us to store vp when someone cast a vote. So basically you can only enable or disable delegation. This mean we need to store on the hub db for each proposal if there is delegation enabled or not. We also need to think how it work if someone delegate voting power in multiple chain.

[zzuziak]

Hi @bonustrack @ChaituVR , what's the status on this one? Does it need a pitch?

[ChaituVR]

Yep need a pitch, I feel now we can support delegation as a core feature (at least for non-overriding strategies)