feat: filter spaces by strategies, plugins and network
#704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
wa0x6e
changed the title
strategies, plugins and network
ChaituVR
requested changes
Oct 25, 2023
| @@ -165,6 +165,21 @@ export async function fetchSpaces(args) { | |||
| orderDirection = orderDirection.toUpperCase(); | |||
| if (!['ASC', 'DESC'].includes(orderDirection)) orderDirection = 'DESC'; | |||
|
|
|||
| if (where.strategies_in) { | |||
| queryStr += " AND JSON_OVERLAPS(JSON_EXTRACT(settings, '$.strategies[*].name'), JSON_ARRAY(?))"; | |||
There was a problem hiding this comment.
It only returns spaces that return space that uses only one strategy, it should return any space that use the strategy being passed
For example if space A is using ticket and erc721 and space B is using just ticket strategy,
now if we request with strategies_in:["ticket"] it return only space B, it should return space A too
There was a problem hiding this comment.
It should be the case already, that's the job of JSON_OVERLAPS. Do you have a specific example I can test ?
Running the query in the description is giving me spaces using multiple strategies
"strategies": [
{
"name": "whitelist"
},
{
"name": "delegation"
},
{
"name": "moloch-all"
},
{
"name": "loot-character-guilds"
},
{
"name": "rocketpool-node-operator"
},
{
"name": "honeyswap"
},
{
"name": "xdai-stake-holders"
},
{
"name": "yearn-vault"
}
],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #548
Fix #535
Add
strategies_inandplugins_infilter to Space.This allow query such as:
Those filters behave differently than the proposal's
strategies_contains.strategies_containsis using string search, and can match anything, such as{.strategies/plugins_infilter will exact match the strategy/plugin name.Feature has been applied to Proposal via #705
The strategies search only apply to level 2 strategies, and will not match nested strategies
Creating the following indices will improve search performance
The goal of those new filters will be to enable the snapshot UI to show the list of spaces using specific network/strategy/plugin
Note
JSON_OVERLAPSrequire Mysql version >= 8.0.17