🧿 Current issues / What's wrong ?

When computing final proposal scores, some computation fail with the sql ER_WARN_DATA_OUT_OF_RANGE error.

This happens when the total scores returned by the strategies exceed the allowed size for the SQL column (decimal(64,30)). Those kind of error happen when the total score is something like 1e47

💊 Fixes / Solution

Fix #279
Fix #281
Fix SNAPSHOT-SEQUENCER-2P

In case total score is invalid, rescue the error, and return an appropriate message to show when calling /scores/proposalID.

🚧 Changes

• In case of ER_WARN_DATA_OUT_OF_RANGE on a closed proposal, mark its score_state as invalid
• Return {"error":"failed","message":"Invalid out of range score"} when computing fail with out-of-range score, when asked via /scores/:proposalId

🛠️ Tests

• Need to test local, by copying the space, votes 0xdc4c6a40bdfb106006507c61237a2f1a4db6b721e0b8444359e7bfcc9b83f5e9
• Set the proposal scores_state to pending in the db
• Call sequencer: http://localhost:3001/scores/0xdc4c6a40bdfb106006507c61237a2f1a4db6b721e0b8444359e7bfcc9b83f5e9
• It should return {"error":"failed","message":"Invalid out of range score"}
• The scores_state should be updated to invalid

If the proposal was not closed yet, it should not set the scores_state to invalid, but call to sequencer should still return the same error message

Other

Additionally, should we update https://github.com/snapshot-labs/snapshot-strategies?tab=readme-ov-file#code to define guideline about the score value ? (max value, best practice, etc ...)