Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate strategy "pagination" #834

Open
2 tasks
bonustrack opened this issue Sep 16, 2022 · 6 comments · Fixed by snapshot-labs/snapshot-v1#3229
Open
2 tasks

Deprecate strategy "pagination" #834

bonustrack opened this issue Sep 16, 2022 · 6 comments · Fixed by snapshot-labs/snapshot-v1#3229

Comments

@bonustrack
Copy link
Member

bonustrack commented Sep 16, 2022

The strategy code should be on the Score API cuz we still need pagination there, but we should remove it as a strategy.

  • Make it impossible to select this strategy in space settings on UI and hub
    as mentioned here Deprecate strategy "multichain" #688
  • Once we do the announcement about this, we can remove this strategy
@emnul
Copy link
Contributor

emnul commented Oct 12, 2022

This issue can be assigned to me. I'm currently working on a fix.

@emnul
Copy link
Contributor

emnul commented Oct 14, 2022

PR snapshot-labs/snapshot-v1#3229 removes the pagination strategy from the UI. Technically someone can still update their space strategy setting by calling the hub api, but I feel like removing the strategy from the UI is sufficient enough. However, I can still make changes to the snapshot-hub if you disagree with my assessment.

@emnul
Copy link
Contributor

emnul commented Nov 11, 2022

@bonustrack just wanted to confirm with you that this bounty has been completed.

@mudgen
Copy link

mudgen commented Dec 4, 2022

I need to use the "pagination" strategy. If I cannot use it, then what do I do instead?

@zzuziak
Copy link
Contributor

zzuziak commented Jan 30, 2023

Hey @bonustrack, can we close this issue?

@ChaituVR
Copy link
Member

@zzuziak We should have a way to announce "pagination" and "multichain" strategies will be deprecated. to give some time for everyone to move to normal strategies then we can remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants