-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use graphql directly #102
Open
wa0x6e
wants to merge
6
commits into
master
Choose a base branch
from
call-hub-directly
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@wa0x6e Could you resolve conflicts 🙈 i missed it last time |
done |
We are not using |
done |
ChaituVR
reviewed
Sep 26, 2023
Sentry issue: SNAPSHOT-WEBHOOK-S |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧿 Current issues / What's wrong ?
Hub queries are send via snapshot.js SDK, using the
snapshot.utils.subgraphRequest
function. While this function is quite practical, it does have limit, and is not adapted when the hub database is part of the core function.We can not customize the fetch request.
We should query the hub using apollo, like on envelop and sidekick
💊 Fixes / Solution
Fix #97
Fix SNAPSHOT-WEBHOOK-7
🚧 Changes
keep-alive
connection while connecting to the hub🛠️ Tests
yarn dev
it should run and process events