Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use -1 in OZVotes and CompVote #240

Open
pscott opened this issue Aug 17, 2023 · 0 comments
Open

do not use -1 in OZVotes and CompVote #240

pscott opened this issue Aug 17, 2023 · 0 comments
Assignees

Comments

@pscott
Copy link
Collaborator

pscott commented Aug 17, 2023

This opens up a double vote attack because we're not using the snapshot block number.

This was originally designed so that users could vote exactly when the voting period starts but we (in a DM conversation with @Orland0x ) decided the risk is not worth (it's easy to shoot yourself in the foot).

@pscott pscott self-assigned this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant