Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: add positive int validation for voting delay and min/max period #629

Open
wa0x6e opened this issue Aug 14, 2024 · 2 comments
Open

bug: add positive int validation for voting delay and min/max period #629

wa0x6e opened this issue Aug 14, 2024 · 2 comments
Labels
area: UI bug Something isn't working

Comments

@wa0x6e
Copy link
Contributor

wa0x6e commented Aug 14, 2024

Currently, the voting delay, and min/max end period form is accepting negative value, which will trigger "Out of bound error" on save.

We should add validation to this form to only accept positive number

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Aug 14, 2024

Passing an negative value in hours/minute crash the page with the error

Uncaught (in promise) Maximum recursive updates exceeded in component <Editable>. This means you have a reactive effect that is mutating its own dependencies and thus recursively triggering itself. Possible sources include component template, render function, updated hook or watcher source function.```

@wa0x6e wa0x6e added bug Something isn't working area: UI labels Aug 14, 2024
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Aug 14, 2024

Getting the same error with the proposal threshold input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant