Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watchmarker on right side (recommended?) no longer showing, even after manual sync #134

Open
Mycohl opened this issue Dec 15, 2024 · 6 comments

Comments

@Mycohl
Copy link

Mycohl commented Dec 15, 2024

Appears to be happening (when logged in, obviously) in Firefox and Chrome.

This may be a duplicate of #114 but I'm not sure.

I've performed a sync by clicking the button under the "Youtube" section, but the issue persists.

watch-marker

@sniklaus
Copy link
Owner

sniklaus commented Jan 9, 2025

I just released version 4.7.0 (already live on Firefox, still pending on Chrome), did this update resolve your issue by chance?

@Mycohl
Copy link
Author

Mycohl commented Feb 18, 2025

did this update resolve your issue by chance?

It's difficult to determine, without knowing the nature of the issue or what was changed.

I still have frequent absence of the Watchmarker, although now I find that manually syncing resolves the issue. However, I don't feel that I should have to manually sync my browser history every 48 hours. Why is the extension failing to read my browser history? (This is on a Firefox fork, for the record.)

Also, sometimes I have to disable and enable the extension multiple times for it to show up. Today, I found that I was unable to click the extension in the FF extensions drop-down to open the settings. I had to go into extension management, disable and enable it, and then click the hamburger menu to get into it.

Additionally, I'm now seeing the Youtube "watched" bar on top of the Watchmarker. This wasn't the case before.

Image

If this is intended behavior, I can probably deal with it, but having to manually sync every couple of days is tiresome.

@sniklaus
Copy link
Owner

That are a bunch of weird behaviors that I have neither experienced myself nor do I recall having others reported them. 🤔

What is the Firefox fork that you are using? Are they doing some privacy enhancement that might interfere with the background scripts of extensions?

@Mycohl
Copy link
Author

Mycohl commented Feb 19, 2025

That are a bunch of weird behaviors

Another thing I just noticed is that the Watchmarker is appearing over videos that I've only opened in private/incognito windows. These shouldn't be appearing in my browser history, correct? And Youtube shouldn't be reporting them as "watched" by my account, correct? This seems like a bug.

What is the Firefox fork that you are using?

I'm using both Waterfox and Floorp.

Are they doing some privacy enhancement that might interfere with the background scripts of extensions?

I honestly couldn't tell you. If there are particular logs or other information you would like me to collect, I'm happy to do so. If you'd like me to attempt to repro with Ubuntu's repo firefox, I can work on getting that set up.

@sniklaus
Copy link
Owner

Another thing I just noticed is that the Watchmarker is appearing over videos that I've only opened in private/incognito windows. These shouldn't be appearing in my browser history, correct? And Youtube shouldn't be reporting them as "watched" by my account, correct? This seems like a bug.

Do you have "mark a video as watched once it has been opened in the browser" enabled in the settings? If so then it would also be added to the Watchmarker history in private sessions. So either disable that setting or don't allow the extension to run in private windows. 👍

I'm using both Waterfox and Floorp. I honestly couldn't tell you. If there are particular logs or other information you would like me to collect, I'm happy to do so. If you'd like me to attempt to repro with Ubuntu's repo firefox, I can work on getting that set up.

I do wonder whether vanilla Firefox would behave as expected. 🤔

@Mycohl
Copy link
Author

Mycohl commented Feb 25, 2025

So either disable that setting or don't allow the extension to run in private windows. 👍

I'm not sure how it was enabled for private windows to begin with, but I've disabled that now.

Had to toggle it off and on again, I do notice that it happens after I reboot, not just when I restart the browser. I will try other tests.

I do wonder whether vanilla Firefox would behave as expected. 🤔

I will work on getting that set up sometime this week, hopefully.

EDIT: In light of Mozilla's new Acceptable Use Policy:

https://news.ycombinator.com/item?id=43194536

"One could interpret this all to say that you're not allowed to view or download porn via Firefox"

And considering that porn sites are literally the only use case I have for mainline FF, I think I will just deal with the bugs, rather than risk giving any of my credentials to Mozilla Corporation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants