auto-check still missing some replacement items

[plastikfan]

No description provided.

[plastikfan]

The extra auto-check output reveals 2 points worthy of note:

• first the replacement text is blank ("name: " should be "name: new-repo-name")
• not selecting the expected workflow files:

  🎯 --->        title: 💥 update-workflow-names
  ✅ ---> file pattern: Taskfile.yml
  ✅ --->         from: .github/workflows
  ✅ --->       target: name: Arcadia
  ✅ --->  replacement: name:
  ✔️ --->  DONE

and the culprit function is:

function update-workflow-names() {
  local repo=$1
  local owner=$2
  local from=.github/workflows
  local file_pattern=*.yml
  local target="name: Arcadia"
  local tc_repo="$(echo ${repo:0:1} | tr '[:lower:]' '[:upper:]')${repo:1}"
  local replacement="name: $tc_repo"
  update-all-generic "💥 update-workflow-names" $repo $owner $from $file_pattern "$target" $replacement
}

If we invoke manually, ie defined repo and owner, then invoke the function, it works as expected:

repo=trixy
owner=snivilised
. ./scripts/automate-checklist.sh
update-workflow-names $repo $owner
  🎯 --->        title: 💥 update-workflow-names
  ✅ ---> file pattern: *.yml
  ✅ --->         from: .github/workflows
  ✅ --->       target: name: Arcadia
  ✅ --->  replacement: name: Trixy
.github/workflows/release-workflow.yml
.github/workflows/ci-workflow.yml
  ✔️ --->  DONE

So the function works in isolation but not in the batch, arghh!

[plastikfan]

Ok, try moving the function call to another point in the batch to see what effect it has and whether that exposes the root cause.

[plastikfan]

changing the order makes no difference:

Run . ./scripts/automate-checklist.sh
---> 😎 OWNER: snivilised
---> 🧰 REPO: trixy

  🎯 --->        title: 💥 update-workflow-names
  ✅ ---> file pattern: Taskfile.yml
  ✅ --->         from: .github/workflows
  ✅ --->       target: name: Arcadia
  ✅ --->  replacement: name:
  ✔️ --->  DONE

[plastikfan]

The problem might be because gh-actions is trying to run a file that we're are trying to modify.