Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix language file loading #20

Closed
plastikfan opened this issue Aug 1, 2022 · 0 comments
Closed

fix language file loading #20

plastikfan opened this issue Aug 1, 2022 · 0 comments
Assignees
@plastikfan
Labels
bug Something isn't working

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Aug 1, 2022 •
edited
Loading

the internal function createLocaliser in 18n.go, unconditionally loads the us english file. This needs to be fixed by loading it only if necessary and also it means the file needs to be part of the deploy list so that it's accessible at run time.

This issue depends on #17
@plastikfan plastikfan added the bug Something isn't working label Aug 1, 2022
@plastikfan plastikfan self-assigned this Aug 1, 2022
@plastikfan plastikfan mentioned this issue Aug 1, 2022
Closed
plastikfan added a commit that referenced this issue Aug 2, 2022
@plastikfan
ref: load language file depending on requested language tag (#20)
7ea7374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plastikfan plastikfan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plastikfan