Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to launcher PR creation process #18

Open
geoand opened this issue Feb 28, 2019 · 0 comments
Open

Add check to launcher PR creation process #18

geoand opened this issue Feb 28, 2019 · 0 comments

Comments

@geoand
Copy link
Member

geoand commented Feb 28, 2019

When executing create launcher pr if the version is incorrect a PR is nevertheless created that only updates a metadata.yml file.

A good user experience improvement would be to check if there are any boosters tags for the version specified and if not to fail the command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geoand