SNOW-1619616: Failing tests of [Small|Big|]IntToScaledFixedConverter for non-standard LOCALE

[bauer-at-work]

1. What version of JDBC driver are you using?
   latest from git

2. What operating system and processor architecture are you using?
   Fedora 40, amd64

3. What version of Java are you using?
   21

4. What did you do?
   ./mvnw clean verify

5. What did you expect to see?

   all test successful.
   However, three tests (SmallInt, Int, BigInt conversion) were failing.

For example,

test IntToFixedConverterTest::testFixedWithScale()

Test run with standard system settings

L130 converter.toString(i): Here, a value in the form of 1,234 is returned.

L141 expectedVal.toString(): This returns 1.234.

Test run with LC_ALL=C

Test completes successfully

SUMMARY

the [Small|Big|]IntToScaledConvert classes are not locale-agnostic and run into failures depending on the locale configuration of the system.

I believe that either

• the tests should take the locale into account
• there should be new tests that assert correct handling of locale settings
• the README or developer notes should mention to run with LC_ALL=C or something along those lines

[bauer-at-work]

Hi, any update? it has been 6 months...

[sfc-gh-wfateem]

Hi @bauer-at-work,
I haven't gotten around to this so I apologize for the delay.
I think the quickest option right now is to add a note in README as you suggested.

Did you have any reservations about that approach? Has the approach of using the environment variable LC_ALL=C been working well for you or did you run into a different problem making this a more urgent issue?

[bauer-at-work]

Hi, yes, my approach still worked fine. I re-discovered my own issue after coming back to compile the JDBC driver after a few months. Having a note in the README would we a good method to get all required info into one place. Thank you!

…

-- Best regards Michael

-------- Ursprüngliche Nachricht -------- Von: Waleed Fateem ***@***.******@***.***%3e>> Antwort an: snowflakedb/snowflake-jdbc ***@***.******@***.***%3e>> An: snowflakedb/snowflake-jdbc ***@***.******@***.***%3e>> Kopie: Michael Bauer ***@***.******@***.***%3e>>, Mention ***@***.******@***.***%3e>> Betreff: Re: [snowflakedb/snowflake-jdbc] SNOW-1619616: Failing tests of [Small|Big|]IntToScaledFixedConverter for non-standard LOCALE (Issue #1867) Datum: 06.02.2025 18:06:42 Hi @bauer-at-work<https://github.com/bauer-at-work>, I haven't gotten around to this so I apologize for the delay. I think the quickest option right now is to add a note in README as you suggested. Did you have any reservations about that approach? Has the approach of using the environment variable LC_ALL=C been working well for you or did you run into a different problem making this a more urgent issue? — Reply to this email directly, view it on GitHub<#1867 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHVSI45H2AIP7BXXUTZ7B432OOJCFAVCNFSM6AAAAABMH3V2ZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBQGQ4DSNJYHE>. You are receiving this because you were mentioned.Message ID: ***@***.***>