Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate Factotum factfile arguments #1

Open
ungn opened this issue Apr 12, 2017 · 0 comments
Open

Remove duplicate Factotum factfile arguments #1

ungn opened this issue Apr 12, 2017 · 0 comments
Assignees

Comments

@ungn
Copy link
Contributor

ungn commented Apr 12, 2017

When starting up factotum-server, --webhook endpoint and --no-colour flag can be set so that these are applied to every call to factotum as default values.

At the moment it is blindly appending these args to the end of the factotum factfile-args, which are passed in the JSON body of the POST request. If those args exist in the factfile-args, the args are duplicated and cause the factotum call to fail (only expects one of each, at most).

Change logic - only append the default args from factotum-server if those args are not present in the incoming factfile-args.

@ungn ungn self-assigned this Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant