Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(website/admin): raisenow as payment category #670

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

ssandino
Copy link
Member

@ssandino ssandino commented Dec 7, 2023

No description provided.

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
public ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 4:20am

Copy link

github-actions bot commented Dec 7, 2023

Visit the preview URL for this PR (updated for commit f485371):

https://si-admin-staging--pr670-sandino-adding-twint-d4ypz20e.web.app

(expires Mon, 18 Dec 2023 04:20:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676

@ssandino
Copy link
Member Author

ssandino commented Dec 8, 2023

Admin Tool:
Successfully tested the assignment of new categories in the Admin tool. The functionality operates as expected without issues.
Screenshot 2023-12-08 at 16 28 14

Donators dashboard on website:
Confirmed that the new category assignments are properly reflected on the website's payments dashboard.
Screenshot 2023-12-08 at 16 28 03

Potential Impact on Transparency Calculations:
@mkue, a point for your consideration: I'm not certain if these changes could affect transparency calculations. My assumption is that it wouldn't, since the calculations seem to be independent of source category.

@mkue
Copy link
Contributor

mkue commented Dec 9, 2023

I wonder if this category makes sense though. Wouldn't make it more sense if the new source would be "RaiseNow"?

The thing is that Stripe will most likely support Twint soon (based on information that I have from you🙈). What do we do then?

I think Twint should only be the source if money is directly twinted to us and not via an intermediary like RaiseNow.

What do you think?

@ssandino
Copy link
Member Author

ssandino commented Dec 9, 2023

@mkue you got a good point. it's more a fix for the twint campaign which is launched in these days (so people are not confused, when it says "cash" in their dashboard)

A good solution that takes into account your valid point and also be beneficial to the user would be:

In the admin tool we use the actual source:

  • stripe
  • raisenow (instead of stripe)
  • cash
  • ...

In the user dashboard we show rather payment method (this is a bit what users care about as they don't know stripe, nor raisenow):

  • if source = stripe, then show "credit card"
  • if source = raisenow, then we show "twint"
  • if source = cash, then show "credit card"

It still not perfect, as the Apple Pay and Google Pay contributions are not shown as payment method, for this we would have to pull the data from Stripe (not sure what we get as data from them for each payment)

Copy link

github-actions bot commented Dec 11, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://socialincome-san.github.io/public/pr-preview/pr-670/
on branch gh-pages at 2023-12-11 04:20 UTC

@mkue
Copy link
Contributor

mkue commented Dec 11, 2023

ok, this seems reasonable for the moment👌🏼 i'll update it.

@mkue mkue changed the title feature(website/admin): Twint as payment category feature(website/admin): raisenow as payment category Dec 11, 2023
@mkue mkue merged commit c5dbc61 into main Dec 11, 2023
21 checks passed
@mkue mkue deleted the sandino/adding-twint-category branch December 11, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants