Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App data retriever memory leak - Blows up scraping scraping app data. #94

Open
AdamSlack opened this issue Sep 22, 2017 · 4 comments
Open
Assignees
Labels

Comments

@AdamSlack
Copy link
Collaborator

Retriever fetches over 500k search terms and then collects 120 sets of app data for each search term. JS then ran out of memory. Rip.

@AdamSlack AdamSlack added the bug label Sep 22, 2017
@AdamSlack AdamSlack self-assigned this Sep 22, 2017
@AdamSlack
Copy link
Collaborator Author

fixed, doing it a search term at a time now. donezo.

@AdamSlack AdamSlack reopened this Sep 22, 2017
@AdamSlack
Copy link
Collaborator Author

Promises not releasing memory. What is life.

@sauyon
Copy link
Collaborator

sauyon commented Sep 22, 2017

incredible

@AdamSlack
Copy link
Collaborator Author

potentially narrowed down to two things.

One:
However i'm going over all search terms in the DB is leading to there being one massive long promise chain that mean the GC can't do its job. I've tried doing it a couple of ways now. each of them lead to mem leak.

Two:
The promises aren't actually the issue and its the db.js causing the issues. the pooling for postgres client connections might not be releasing properly when complete. I think its more likely to be One though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants