Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloader needs to know if version has changed... #27

Open
deanott opened this issue Jul 25, 2017 · 2 comments
Open

Downloader needs to know if version has changed... #27

deanott opened this issue Jul 25, 2017 · 2 comments

Comments

@deanott
Copy link
Member

deanott commented Jul 25, 2017

The downloader currently queries the databse for apps that have not been downloaded.
It then attempts to download that app and if successful it then updates the database.

I do the downloading updates of the database in batches right now.

There is no way currently with the the downloader tool on the play store to ask for a specific version, this would require another query to check. Do not really want to bring in all the retreiver to the downloader.
If we setup up that we can pass a sort by oldest we could also also remove dates that are too old? reducing only the chance of the version mismatching. Unless we get unlucky and the second we scrape we have a update. @AdamSlack @sauyon thoughts?

@AdamSlack
Copy link
Contributor

Personally i think that we should only really care about the latest versions of apps. By all means we should keep a record of previous play store apps, but maybe it should be in a separate table.

We're wanting to see what is being done with your personal information, its more important to see what they're doing with the latest version as opposed to one you can't download any more from 2 years ago.

That said it would be interesting/useful to know about situations like when a previous app didn't do anything particularly unethical, but then started to do so. that way you could know not to update your app or something.

@sauyon
Copy link
Contributor

sauyon commented Jul 26, 2017

Our table is setup in such a way that all versions are recorded as per the wishes of the rest of the team (ie Max, mostly).

I think I suggested checking that the last updated was within a reasonable range (2 days?) before downloading the app.

Another possibility is that the analyzer (now that it can identify versions) can simply move the apk to the correct version in the event that the version is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants