JSString support

[dmjio]

@soenkehahn, hello :)

What do you think about adding JSString support?

-- from JSString

#ifdef __GHCJS__
import Data.JSString 
import Data.JSString.Text
#endif

....

#ifdef __GHCJS__
instance ConvertibleStrings JSString JSString where
    convertString = id

instance ConvertibleStrings JSString String where
    convertString = unpack'

instance ConvertibleStrings JSString StrictByteString where
    convertString = Data.Text.Encoding.encodeUtf8 . textFromJSString

instance ConvertibleStrings JSString LazyByteString where
    convertString = Data.Text.Lazy.Encoding.encodeUtf8 . lazyTextFromJSString

instance ConvertibleStrings JSString StrictText where
    convertString = textFromJSString

instance ConvertibleStrings JSString LazyText where
    convertString = lazyTextFromJSString
#endif

[soenkehahn]

Yeah, I'd be fine with merging a PR.

I wonder whether this should better be in a separate module Data.String.Conversions.GHCJS which -- through CPP -- would be an empty module on ghc.

[dmjio]

Sounds good, was a bit worried about orphans if there was a separate module (unless the class definition was copied as well). Might be able to skip CPP altogether if cabal file was arranged like so:

library
   if impl(ghcjs)
      hs-source-dirs: ghcjs-src
      exposed-modules: Data.String.Conversions
      build-depends: ghcjs-base
   else
     hs-source-dirs: src
     exposed-modules: Data.String.Conversions
     build-depends: text, bytestring

Unsure if hpack allows for impl(ghcjs) syntax though

[dmjio]

It seems like hpack supports conditionals

when:
  - condition: flag(fast)
    then:
      ghc-options: -O2
    else:
      ghc-options: -O0

[soenkehahn]

I think I would still prefer CPP over impl(ghcjs).

[dmjio]

Ok, that's fine too. So then should we do the single module approach, but
#ifdef on imports and instances?

On Wed, Nov 2, 2016 at 1:57 PM, Sönke Hahn [email protected] wrote:

I think I would still prefer CPP over impl(ghcjs).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA1bPM2xQogLbgYi5309JXpGOk1SWIulks5q6N0ggaJpZM4Km5I6
.

Cell: 1.630.740.8204

[soenkehahn]

Yes, please.