diff --git a/jraft-core/src/main/java/com/alipay/sofa/jraft/entity/PeerId.java b/jraft-core/src/main/java/com/alipay/sofa/jraft/entity/PeerId.java index 6851f1616..8c9ec8b4e 100644 --- a/jraft-core/src/main/java/com/alipay/sofa/jraft/entity/PeerId.java +++ b/jraft-core/src/main/java/com/alipay/sofa/jraft/entity/PeerId.java @@ -192,7 +192,7 @@ public String toString() { * */ public boolean parse(final String s) { - if (StringUtils.isEmpty(s)) { + if (StringUtils.isEmpty(s) || StringUtils.isBlank(s)) { return false; } diff --git a/jraft-core/src/test/java/com/alipay/sofa/jraft/entity/PeerIdTest.java b/jraft-core/src/test/java/com/alipay/sofa/jraft/entity/PeerIdTest.java index a83910a20..0fbebedd0 100644 --- a/jraft-core/src/test/java/com/alipay/sofa/jraft/entity/PeerIdTest.java +++ b/jraft-core/src/test/java/com/alipay/sofa/jraft/entity/PeerIdTest.java @@ -25,6 +25,14 @@ public class PeerIdTest { + @Test + public void testToStringPeerIdFalse() { + final PeerId serverId = new PeerId(); + assertFalse(serverId.parse(null)); + assertFalse(serverId.parse("")); + assertFalse(serverId.parse(" ")); + } + @Test public void testToStringParse() { final PeerId peer = new PeerId("192.168.1.1", 8081, 0);