Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppDelegateSubscriber / Config Plugins #32

Open
EvanBacon opened this issue Feb 16, 2022 · 1 comment
Open

AppDelegateSubscriber / Config Plugins #32

EvanBacon opened this issue Feb 16, 2022 · 1 comment
Labels

Comments

@EvanBacon
Copy link

To auto configure react-native-maps in expo prebuild we use some dangerous mods. It'd be a bit better to implement the ReactDelegate: example.

This could setup Google Maps automatically ([GMSServices provideAPIKey:apiKey];) in the applicationDidLaunch method, with this system it would be standard to read the API key from the Info.plist which would be injected via config plugins.

Alternatively, the whole 'provide API key' could just be exposed via JS and invoked before the app renders any Google Maps, I'm not familiar enough with API to say if this works.

Anyways, great job on the library so far! Really excited to see a new maps library.

@szdziedzic
Copy link
Collaborator

Thank you so much! This is something we definitely want to do.

@szdziedzic szdziedzic added the ios label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants