From 1c3639eb6cfa7c6925659c801d9780605d51e758 Mon Sep 17 00:00:00 2001 From: Tomek Zawadzki Date: Tue, 28 Jan 2025 17:44:03 +0100 Subject: [PATCH] Improve readability of `HEADER_SEARCH_PATHS` in podspecs (#6949) ## Summary This PR improves readability of `HEADER_SEARCH_PATHS` value in RNReanimated.podspec and RNWorklets.podspec by passing all flags as an array of strings and calling `.join(' ')` at the end. ## Test plan --- packages/react-native-reanimated/RNReanimated.podspec | 11 ++++++++++- packages/react-native-worklets/RNWorklets.podspec | 11 ++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/packages/react-native-reanimated/RNReanimated.podspec b/packages/react-native-reanimated/RNReanimated.podspec index 03255d180b0..9d2832d2f1d 100644 --- a/packages/react-native-reanimated/RNReanimated.podspec +++ b/packages/react-native-reanimated/RNReanimated.podspec @@ -118,7 +118,16 @@ Pod::Spec.new do |s| s.pod_target_xcconfig = { "USE_HEADERMAP" => "YES", "DEFINES_MODULE" => "YES", - "HEADER_SEARCH_PATHS" => '"$(PODS_TARGET_SRCROOT)/ReactCommon" "$(PODS_TARGET_SRCROOT)" "$(PODS_ROOT)/RCT-Folly" "$(PODS_ROOT)/boost" "$(PODS_ROOT)/boost-for-react-native" "$(PODS_ROOT)/DoubleConversion" "$(PODS_ROOT)/Headers/Private/React-Core" "$(PODS_ROOT)/Headers/Private/Yoga"', + "HEADER_SEARCH_PATHS" => [ + '"$(PODS_TARGET_SRCROOT)/ReactCommon"', + '"$(PODS_TARGET_SRCROOT)"', + '"$(PODS_ROOT)/RCT-Folly"', + '"$(PODS_ROOT)/boost"', + '"$(PODS_ROOT)/boost-for-react-native"', + '"$(PODS_ROOT)/DoubleConversion"', + '"$(PODS_ROOT)/Headers/Private/React-Core"', + '"$(PODS_ROOT)/Headers/Private/Yoga"', + ].join(' '), "FRAMEWORK_SEARCH_PATHS" => '"${PODS_CONFIGURATION_BUILD_DIR}/React-hermes"', "CLANG_CXX_LANGUAGE_STANDARD" => "c++17", "GCC_PREPROCESSOR_DEFINITIONS[config=Debug]" => gcc_debug_definitions, diff --git a/packages/react-native-worklets/RNWorklets.podspec b/packages/react-native-worklets/RNWorklets.podspec index 9dcdc62ff15..4c2ffd63351 100644 --- a/packages/react-native-worklets/RNWorklets.podspec +++ b/packages/react-native-worklets/RNWorklets.podspec @@ -56,7 +56,16 @@ Pod::Spec.new do |s| s.pod_target_xcconfig = { "USE_HEADERMAP" => "YES", "DEFINES_MODULE" => "YES", - "HEADER_SEARCH_PATHS" => '"$(PODS_TARGET_SRCROOT)/ReactCommon" "$(PODS_TARGET_SRCROOT)" "$(PODS_ROOT)/RCT-Folly" "$(PODS_ROOT)/boost" "$(PODS_ROOT)/boost-for-react-native" "$(PODS_ROOT)/DoubleConversion" "$(PODS_ROOT)/Headers/Private/React-Core" "$(PODS_ROOT)/Headers/Private/Yoga"', + "HEADER_SEARCH_PATHS" => [ + '"$(PODS_TARGET_SRCROOT)/ReactCommon"', + '"$(PODS_TARGET_SRCROOT)"', + '"$(PODS_ROOT)/RCT-Folly"', + '"$(PODS_ROOT)/boost"', + '"$(PODS_ROOT)/boost-for-react-native"', + '"$(PODS_ROOT)/DoubleConversion"', + '"$(PODS_ROOT)/Headers/Private/React-Core"', + '"$(PODS_ROOT)/Headers/Private/Yoga"', + ].join(' '), "FRAMEWORK_SEARCH_PATHS" => '"${PODS_CONFIGURATION_BUILD_DIR}/React-hermes"', "CLANG_CXX_LANGUAGE_STANDARD" => "c++17", }