Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Captured path segments are not URL-decoded in ZIO HTTP + Captured path segments don't treat '+' properly in finatra and vertx #3384

Closed
finalchild opened this issue Dec 11, 2023 · 1 comment · Fixed by #3386

Comments

@finalchild
Copy link
Contributor

finalchild commented Dec 11, 2023

Tapir version: 1.9.4

Scala version: 3.3.1

Describe the bug

What is the problem?

  1. Captured path segments should be URL-decoded, but it's not only in ZIO HTTP. See [BUG] Captured path segments are not URL-decoded #896 and fix(server): URL-decode captured path segments #1062.

Behavior when using Vert.X: (correct)
image

Behavior when using ZIO HTTP: (wrong)
image

  1. Captured path segments should not treat '+' as ' '. (This "plus as space" behavior is specific to query strings and doesn't extend to path strings.) This is a bug introduced in fix(server): URL-decode captured path segments #1062.

Behavior when using http4s: (correct)
image

Behavior when using Vert.X: (wrong)
image

Finatra upstream has this bug too: twitter/finatra#590

@finalchild finalchild changed the title [BUG] Captured path segments are not URL-decoded in ZIO HTTP [BUG] Captured path segments are not URL-decoded in ZIO HTTP + Captured path segments don't treat '+' properly in finatra and vertx Dec 11, 2023
@finalchild
Copy link
Contributor Author

I wrote a fix at #3386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant