Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🤔 Add margin top to all components that use "Help-txt" #1599

Open
11 tasks
MartaPintoTeixeira opened this issue Oct 29, 2024 · 0 comments
Open
11 tasks
Assignees
Labels
🔧 code needs changes in code 🎨 figma needs changes in Figma

Comments

@MartaPintoTeixeira
Copy link
Contributor

MartaPintoTeixeira commented Oct 29, 2024

Current behavior

There is no space between "Help-text" and the input boxes - Margin-top is not active.
There is no space between "max attribute" or "min attribute" etc .. and the input boxes - Margin-top is not active. - code only
https://solid-design-system.fe.union-investment.de/x.x.x/storybook/?path=/docs/components-sd-input--docs

Expected behavior

We should apply the same margin-top that we have in between "Error message" and input box.
Which in FIGMA is: 4 in figma.
Which in CODE is: margin-top: var(--sd-spacing-2, .5rem);

Steps to reproduce

Open storybook and figma.

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 code needs changes in code 🎨 figma needs changes in Figma
Projects
None yet
Development

No branches or pull requests

2 participants