Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 👷 fix "deployment failed" message on main #1627

Open
6 tasks
mariohamann opened this issue Nov 8, 2024 · 0 comments
Open
6 tasks

ci: 👷 fix "deployment failed" message on main #1627

mariohamann opened this issue Nov 8, 2024 · 0 comments

Comments

@mariohamann
Copy link
Contributor

mariohamann commented Nov 8, 2024

User Story

As a developer of the Solid Design System, I would like to not be irritated from that the deployment on GitHub pages failed, although it worked.

CleanShot 2024-11-08 at 13 04 32

CleanShot 2024-11-08 at 13 01 41

Suggested Solution

On main there's no comment to update, only on PRs. That's why the last step is failing. We should have an if clause that checks, whether we are in a PR or not.

Environment (GitHub Actions or Azure DevOps)

GitHub Actions

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Implementation works successfully on feature branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant