Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagged template function doesn't trigger rerender #2377

Closed
gineika opened this issue Dec 8, 2024 · 5 comments · Fixed by ryansolid/dom-expressions#389
Closed

Tagged template function doesn't trigger rerender #2377

gineika opened this issue Dec 8, 2024 · 5 comments · Fixed by ryansolid/dom-expressions#389

Comments

@gineika
Copy link

gineika commented Dec 8, 2024

Describe the bug

No response

Your Example Website or App

https://playground.solidjs.com/anonymous/d74ac8bc-cfd4-4e03-861d-17456c31ab5e

Steps to Reproduce the Bug or Issue

No response

Expected behavior

https://playground.solidjs.com/anonymous/aa9945d4-45d1-4b1d-aa1d-7fb64e7ba92e

Screenshots or Videos

No response

Platform

Playground

Additional context

No response

@atk
Copy link
Contributor

atk commented Dec 8, 2024

Should be an easy PR. If you don't want to wait, you can probably submit one yourself, otherwise, this goes further down on my TO-DO list.

edemaine added a commit to edemaine/dom-expressions that referenced this issue Dec 9, 2024
edemaine added a commit to edemaine/dom-expressions that referenced this issue Dec 9, 2024
@edemaine
Copy link
Contributor

edemaine commented Dec 9, 2024

I took a stab here: ryansolid/dom-expressions#389

@atk
Copy link
Contributor

atk commented Dec 10, 2024

That is a prerequisite; our Translator function does not yet support template literal arguments. However, we cannot implement them in a typesafe way, see microsoft/TypeScript#33304 - so this is probably on hold for now, as we do not want to give up type safety for the benefit of being able to forgo parentheses.

@edemaine
Copy link
Contributor

I'm not sure I follow, Alex. Are you talking about another project? Solid doesn't have a "translator function". I was just responding to the issue here, which is about tagged templates not being reactive despite involving a function call.

@atk
Copy link
Contributor

atk commented Dec 10, 2024

I thought this was also about our solid-primitive package i18n. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants