Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of "since <time>" #120

Open
OdileDevismesSonos opened this issue Jul 20, 2018 · 2 comments
Open

Handling of "since <time>" #120

OdileDevismesSonos opened this issue Jul 20, 2018 · 2 comments
Assignees
Labels
bug fixpending Fix done. Version with fix will be added to ticket.

Comments

@OdileDevismesSonos
Copy link
Collaborator

OdileDevismesSonos commented Jul 20, 2018

Fr: depuis - à partir de
En: since -from
De: seit - ab

French: "depuis" combined with durations, but not with simple dates
"depuis le 5 janvier": KO
recognized as "le 5 janvier"

"depuis 3 mois": OK
TimeInterval(Between { start: 2018-07-24T00:00:00+02:00, end: 2018-10-24T12:40:43.829472+02:00, precision: Exact, latent: false })

** French: "à partir de": OK
"à partir du 5 janvier": OK
TimeInterval(After(TimeOutput { moment: 2019-01-05T00:00:00+01:00, grain: Day, precision: Exact, latent: false }))

**English: "from", "from...on": KO
"from october 13th": KO
"from october 13th on": KO
recognized as "october 13th"

German: "seit" combined with simple dates, but not with durations
"seit dem 11. januar" : OK
TimeInterval(After(TimeOutput { moment: 2018-01-11T00:00:00+01:00, grain: Day, precision: Exact, latent: false }))

"seit 3 monaten": KO
recognized as "3 monaten"

**German: "ab" (= from, depuis): OK
"ab dem 11. Januar"
TimeInterval(After(TimeOutput { moment: 2018-01-11T00:00:00+01:00, grain: Day, precision: Exact, latent: false }))

@rosastern
Copy link
Collaborator

@Odile-deVismes can we get a few examples of expected/actual behaviours for the problematic cases that you identified?

@OdileDevismesSonos
Copy link
Collaborator Author

OdileDevismesSonos commented Oct 24, 2018

@rosastern I have just updated the description.

@rosastern rosastern added bug and removed helpwanted labels Mar 28, 2019
@rosastern rosastern added the fixpending Fix done. Version with fix will be added to ticket. label Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixpending Fix done. Version with fix will be added to ticket.
Projects
None yet
Development

No branches or pull requests

3 participants