Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check LocalVariableNode.signature to avoid creating Locals with unknown Type #635

Open
swissiety opened this issue Jun 21, 2023 · 0 comments · May be fixed by #789
Open

check LocalVariableNode.signature to avoid creating Locals with unknown Type #635

swissiety opened this issue Jun 21, 2023 · 0 comments · May be fixed by #789
Labels
improvement improve in readability, structure or performance

Comments

@swissiety
Copy link
Collaborator

maybe we can avoid creating Locals with unknown type (sometimes):
LocalVariableNode has a member: signature where we could get type information? (currently we don't)

Location: AsmMethodSource.determineLocalName(int idx) and the method where its we create the actual Local with UnknownType but the name from determineName(..)
@swissiety swissiety added the improvement improve in readability, structure or performance label Jun 21, 2023
oxisto added a commit to oxisto/SootUp that referenced this issue Dec 31, 2023
@oxisto
Use information of operand value to determine type for java locals
cbbd002 
This PR uses the already existing information of the operand's value type to determine the type for java locals. Previously, most of the stack variables were of "unknown" type
.
Fixes soot-oss#635
@oxisto oxisto linked a pull request Dec 31, 2023 that will close this issue
Draft
oxisto added a commit to oxisto/SootUp that referenced this issue Dec 31, 2023
@oxisto
Use information of operand value to determine type for java locals
36de671 
This PR uses the already existing information of the operand's value type to determine the type for java locals. Previously, most of the stack variables were of "unknown" type
.
Fixes soot-oss#635
oxisto added a commit to oxisto/SootUp that referenced this issue Dec 31, 2023
@oxisto
Use information of operand value to determine type for java locals
58d745e 
This PR uses the already existing information of the operand's value type to determine the type for java locals. Previously, most of the stack variables were of "unknown" type
.
Fixes soot-oss#635
oxisto added a commit to oxisto/SootUp that referenced this issue Dec 31, 2023
@oxisto
Use information of operand value to determine type for java locals
726b6df 
This PR uses the already existing information of the operand's value type to determine the type for java locals. Previously, most of the stack variables were of "unknown" type
.
Fixes soot-oss#635
oxisto added a commit to oxisto/SootUp that referenced this issue Dec 31, 2023
@oxisto
Use information of operand value to determine type for java locals
8481c4b 
This PR uses the already existing information of the operand's value type to determine the type for java locals. Previously, most of the stack variables were of "unknown" type
.
Fixes soot-oss#635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement improve in readability, structure or performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use information of operand value to determine type for java locals oxisto/SootUp
1 participant
@swissiety