Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MasterOnly > MainOnly #33

Open
till opened this issue Feb 3, 2023 · 5 comments
Open

MasterOnly > MainOnly #33

till opened this issue Feb 3, 2023 · 5 comments

Comments

@till
Copy link

till commented Feb 3, 2023

Hey,

would you consider a contribution if I either renamed it or added support alongside it?

Also, would you mind rolling another tag at some point?
@sosedoff
Copy link
Owner

sosedoff commented Feb 3, 2023

Do you have a bit more context behind the rename? I do accept PRs if they make sense.

@till
Copy link
Author

till commented Feb 3, 2023

For example this:
https://github.com/github/renaming

@sosedoff
Copy link
Owner

sosedoff commented Feb 3, 2023

That seems reasonable.

We could take a step further and allow setting the required branch, something along the line of cfg.AllowedBranches = ["main"] or cfg.AllowedBranches = func(name) bool.

@till
Copy link
Author

till commented Feb 4, 2023

I like that idea. I can poke around!

till added a commit to hostwithquantum/gitkit-fork that referenced this issue Feb 5, 2023
@till
Update: allow push to certain branches
e2a92c3 
This extends MasterOnly and makes it configurable. The idea is to
set arbitrary branch names which are allowed to be pushed to and
otherwise return an error.

Resolves: sosedoff#33
@till
Copy link
Author

till commented Feb 5, 2023

Made a pass. I'll leave some comments in the PR: #34

till added a commit to hostwithquantum/gitkit-fork that referenced this issue Jun 16, 2023
@till
Update: allow push to certain branches
1d2f53d 
This extends MasterOnly and makes it configurable. The idea is to
set arbitrary branch names which are allowed to be pushed to and
otherwise return an error.

Resolves: sosedoff#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@till @sosedoff