-
Notifications
You must be signed in to change notification settings - Fork 3
Support new sourcecred identities #30
Comments
Are you saying that GitHub users would need to be cross referenced with Discourse, or just that sourcecred would need to produce an equivalent data structure (with user scores) from Discourse? Has that not been finished yet? There are definitely users in discourse, so it should be a doable thing! |
E.g. I'm looking here although I suppose I don't know how the snapshots are processed :P |
Yes I think the end goal is to have GitHub and Discourse users mixed in the same instance, rather than analysing them in isolation. Discourse has users but what I meant is that cross referencing yes. Without that, you may see the same avatar from different sources and with different cred scores. But I'm definitely less active on discourse. On https://discourse.sourcecred.io/t/sneak-peek-sourcecred-discourse-plugin/171 I receive 12 cred. On the GitHub based cred this would be a 26th spot. I.e. just supporting Discourse avatars I would show up twice in a widget. Somewhere on the first row and somewhere further down like the 3rd or 4th row (rows of 10). Instead we should have a "canonical identity" which has the total cred for a person. So in my case 216 from GitHub, 12 from Discourse, which would probably put me back around the 4th or 5th spot. This time without being further down as well. I'm not sure how far along the solution for these shared / canonical identities is. But I do think that should be the starting point for updating the widgets code. Looking at the snapshot, there's already an avatar url template. This might mean part of the widgets code (finding the right avatar url) becomes a plugin responsibility and a similar avatar template might be in the canonical identity. @decentralion can you tell us a bit about how far along this is? |
How would the identities be matched? Email is the most logical thing, but many users choose to not expose their email addresses. An identical username / image could be correct most of the time, but I'm not sure most of the time is foolproof. |
Heya! I'm actually actively working on this on the SourceCred side, with an intention to have a working solution by the end of the week. Here's my plan:
The net result will be a pretty flexible system for doing manual identity resolution. As we polish SourceCred we can build more convenient ways for doing this so that contributors don't need to make pull requests to a config file, but I think starting here will be fine. |
Related: #32 |
Identities are now implemented: sourcecred/sourcecred#1384 |
To answer a question from sourcecred/sourcecred#1360
(referring to the Discourse plugin)
@vsoch the current widgets implementation relies on the format produced by
sourcecred scores <project spec>
. That format has a concept of users which is assumed to be a github user. To support Discourse for the widgets, we would need to have some form of canonical identities introduced here as well and a way to find which avatar goes with that.Edit: Identities are now supported sourcecred/sourcecred#1384
The text was updated successfully, but these errors were encountered: