Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Support Discourse avatars #37

Open
Beanow opened this issue Oct 3, 2019 · 1 comment
Open

Support Discourse avatars #37

Beanow opened this issue Oct 3, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@Beanow
Copy link
Collaborator

Beanow commented Oct 3, 2019

Part of the next SourceCred release will be to support Discourse forums.
It's available in the current master, so for the first widgets release to be compatible with that, we should implement Discourse avatars.

Depends on: #32

Some pointers or a proof of concept to fetch Discourse avatars at all would be great :D

@Beanow Beanow added enhancement New feature or request help wanted Extra attention is needed labels Oct 3, 2019
@Beanow Beanow added this to the 0.1.0 release milestone Oct 3, 2019
@Beanow
Copy link
Collaborator Author

Beanow commented Oct 5, 2019

Interesting comment from @decentralion at #33 (comment)

I'm noting that this code only works for GitHub identities, so it will break with the new scores format (and inclusion of SC and Discourse identities), yes?

Also: this is actually a reason that the scores format with address parts is better than just including aliases, as the address parts for the Discourse address include the server url, while the alias wouldn't. So with the address parts, we could infer the right avatar url for Discourse users.

As a workaround until sourcecred identities support avatars (see sourcecred/sourcecred#1396), the discourse addresses can be parsed to work out the URL from which to fetch avatars and link when clicking the avatar from the SVG.

@Beanow Beanow added good first issue Good for newcomers and removed help wanted Extra attention is needed labels Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant