Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Precise code intelligence for Protobuf #27400

Open
3 tasks
olafurpg opened this issue Nov 11, 2021 · 4 comments
Open
3 tasks

Precise code intelligence for Protobuf #27400

olafurpg opened this issue Nov 11, 2021 · 4 comments
Labels
lang/protobuf team/graph Graph Team (previously Code Intel/Language Tools/Language Platform)

Comments

@olafurpg
Copy link
Member

olafurpg commented Nov 11, 2021

Currently, Sourcegraph does not support precise code intelligence for Protobuf files. We have validated an approach to accomplish this in a way so that cross-language navigation between *.proto files and the generated Protobuf files works as well. This means that "Go to definition" from Go/Java programs will be able to jump to the original *.proto file instead of the generated programs. Likewise, "Find references" on Protobuf symbols will be able to show usages from Go/Java programs.

The approach we have validated works by post-processing the generated LSIF files from lsif-go and lsif-java. Currrently, post-processing LSIF is quite awkward so we're investigating solutions to improve that before shipping Protobuf support.

@olafurpg olafurpg added team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) lang/protobuf labels Nov 11, 2021
@github-actions
Copy link
Contributor

Heads up @macraig - the "team/code-intelligence" label was applied to this issue.

@olafurpg
Copy link
Member Author

The approach we have validated works by post-processing the generated LSIF files from lsif-go and lsif-java. Currrently, post-processing LSIF is quite awkward so we're investigating solutions to improve that before shipping Protobuf support.

Small update: the solution we came up with is RFC 519, which has been approved and we've already made good progress on implementing it. We have a tracking issue for RFC 519 here https://github.com/sourcegraph/sourcegraph/issues/27403

@macraig macraig added team/search-platform Issues owned by the search platform team team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) and removed team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/search-platform Issues owned by the search platform team labels Nov 24, 2021
@github-actions
Copy link
Contributor

Heads up @jjeffwarner - the "team/search-core" label was applied to this issue.

@github-actions
Copy link
Contributor

Heads up @macraig - the "team/code-intelligence" label was applied to this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang/protobuf team/graph Graph Team (previously Code Intel/Language Tools/Language Platform)
Projects
None yet
Development

No branches or pull requests

3 participants