-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notfies :before property doubles the leaf-directory #196
Comments
Nope, it wasn't gone. I just retested with Chef Client 13.2.20 while it was still commented out. Furthermore a colleague of mine has the same problem on Ubuntu 16. |
This is probably caused by the fact that notify :before triggers a why-run. However action :put will call set_put_paths during both the real and the why-run, joining the resource name onto the path twice. |
I'm somewhat concerned by the complete silence. Is there something wrong with the issue? Is there anything I can do to help? Is everyone just on summer vacation? |
Ark resource wasn't supporting whyrun mode because of its overwritting of resource attributes set by user recipes (especially the path attr). By introducing new "internal" resource attribute ("_deploy_path" and "_release_file"), which are set by and only by ark's resource internal implementation, this resource is now whyrun compliant and constructs involving `notifies :action, 'other_resource[name]', :before` are now possible. Signed-off-by: Christophe Sourisse <[email protected]>
I just faced the very same issue on one of my projects, corrected it and saw this 2-year old ticket. |
Ark resource wasn't supporting whyrun mode because of its overwritting of resource attributes set by user recipes (especially the path attr). By introducing new "internal" resource attribute ("_deploy_path" and "_release_file"), which are set by and only by ark's resource internal implementation, this resource is now whyrun compliant and constructs involving `notifies :action, 'other_resource[name]', :before` are now possible. Signed-off-by: Christophe Sourisse <[email protected]>
Ark resource wasn't supporting whyrun mode because of its overwritting of resource attributes set by user recipes (especially the path attr). By introducing new "internal" resource attribute ("_deploy_path" and "_release_file"), which are set by and only by ark's resource internal implementation, this resource is now whyrun compliant and constructs involving `notifies :action, 'other_resource[name]', :before` are now possible. Signed-off-by: Christophe Sourisse <[email protected]>
Ark resource wasn't supporting whyrun mode because of its overwritting of resource attributes set by user recipes (especially the path attr). By introducing new "internal" resource attribute ("_deploy_path" and "_release_file"), which are set by and only by ark's resource internal implementation, this resource is now whyrun compliant and constructs involving `notifies :action, 'other_resource[name]', :before` are now possible. Signed-off-by: Christophe Sourisse <[email protected]>
Ark resource wasn't supporting whyrun mode because of its overwritting of resource attributes set by user recipes (especially the path attr). By introducing new "internal" resource attribute ("_deploy_path" and "_release_file"), which are set by and only by ark's resource internal implementation, this resource is now whyrun compliant and constructs involving `notifies :action, 'other_resource[name]', :before` are now possible. Signed-off-by: Christophe Sourisse <[email protected]>
Ark resource wasn't supporting whyrun mode because of its overwritting of resource attributes set by user recipes (especially the path attr). By introducing new "internal" resource attribute ("_deploy_path" and "_release_file"), which are set by and only by ark's resource internal implementation, this resource is now whyrun compliant and constructs involving `notifies :action, 'other_resource[name]', :before` are now possible. Signed-off-by: Christophe Sourisse <[email protected]>
Ark resource wasn't supporting whyrun mode because of its overwritting of resource attributes set by user recipes (especially the path attr). By introducing new "internal" resource attribute ("_deploy_path" and "_release_file"), which are set by and only by ark's resource internal implementation, this resource is now whyrun compliant and constructs involving `notifies :action, 'other_resource[name]', :before` are now possible. Signed-off-by: Christophe Sourisse <[email protected]>
I'm also affected by exactly this bug. I'm notifying another resource with the :before timing which seems to confuse ark and have the root dictionary doubled. Without the notify it works as expected. |
Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs. |
Closing due to inactivity. If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs. |
I need to check if this is still a bug, but I highly suspect it is! |
Cookbook version
3.1.0
Chef-client version
12.19.36
Platform Details
Windows 10 (15063)
Scenario:
Combining the ark resource :put action with notifies
Steps to Reproduce:
My resource is declared like
Expected Result:
I would expect the zip to be expanded to C:/Temp/app_test
Actual Result:
The zip is expanded to C:/Temp/app_test/app_test.
If I comment out the notifies property, it works correctly.
If I only use notified :immediate or :delayed, it works correctly
The text was updated successfully, but these errors were encountered: