Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should the command buffer size really be capped? #1050

Open
Keksoj opened this issue Dec 8, 2023 · 0 comments
Open

should the command buffer size really be capped? #1050

Keksoj opened this issue Dec 8, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@Keksoj
Copy link
Member

Keksoj commented Dec 8, 2023

Anytime the max_command_buffer_size is too small and we get this error:

channel buffer is full ({0} bytes), cannot grow more

we end up upping the value in the config and we go on.

Is an upper limit really useful? What's the worst that could happen here? Our channels will soon transmit binary serializations of protobuf messages, this leaves little room for errors.

@Keksoj Keksoj added the question label Dec 8, 2023
@Keksoj Keksoj added this to the v0.16.0 milestone Dec 8, 2023
@Keksoj Keksoj self-assigned this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant