Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build actions on pull request and on demand #56

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

mkhansenbot
Copy link
Contributor

Adds build actions: on 'pull_request' will automatically run a build each time a PR is opened, and on 'workflow_dispatch' which will enable a "Run workflow" button on the Actions tab.

Addresses parts of #55

@mkhansenbot
Copy link
Contributor Author

@EzraBrooks - the moveit2 build is failing because the image size is too large
https://github.com/space-ros/docker/actions/runs/5569973214/jobs/10173701615?pr=56#step:4:9742

Do you know how big the moveit2 image is? I believe we have a GH Actions limit around 28GB.

Adds build actions: on 'pull_request'  will automatically run a build each time a PR is opened,  and on 'workflow_dispatch' which will enable a "Run workflow" button on the Actions tab
Building space_robots depends on building moveit2 first, this adds the build flow to the space_robots Docker build
@mkhansenbot
Copy link
Contributor Author

I propose we merge this because it will enable the build on all PRs

Copy link
Member

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always prefer CI run and fail than not run at all.

I'd also like, once this is committed, to make the CI mandatory for merging PRs. (which of course means the next PR has to fix the disk size issue).

@EzraBrooks EzraBrooks merged commit cb745d0 into space-ros:main Jul 27, 2023
2 of 3 checks passed
@mkhansenbot mkhansenbot deleted the add_build_actions branch August 10, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants