Make AudioSystem ZOffset public #5388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
49
to
51
|
|
||
| public virtual float ZOffset { get; protected set; } | ||
| public virtual float ZOffset { get; set; } | ||
|
|
There was a problem hiding this comment.
Is there a reason this is needed? SetZOffset is already public and content setting this isn't handled properly at all ie.
- cvar changes can bulldoze it.
- Overwriting it would mean the max-length adjustments could get bulldozed.
There was a problem hiding this comment.
Because AudioSystem overrides ZOffset that comes from its parent, SharedAudioSystem and when overriding, you can't change the modifiers since you will get CS0507, and this is will not compile.
There was a problem hiding this comment.
Oh... I understood what you meant now. IAudioListener already has a SetZOffset method that is public... I'm sorry for being dumb and will try it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5352.