Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Python 3.13 support #3210

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

TST: Python 3.13 support #3210

wants to merge 1 commit into from
+39 −33

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 1, 2024

Description

This pull request is to add Python 3.13 job. Probably no need for change log unless we need real code changes here.

After merge: Follow up issue to remove -dev tag from Python version spec for 3.13 when stable is available from Actions runner.

Fix #3186

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Oct 1, 2024
@pllim pllim added this to the 4.0 milestone Oct 1, 2024
@pllim
Copy link
Contributor Author

pllim commented Oct 1, 2024

Nope. The stack isn't ready.

@pllim
Copy link
Contributor Author

pllim commented Oct 10, 2024

Looks like bqplot dev cannot build from source in Python 3.13.

On the stable job (where bqplot stable is not giving me a problem), I ran into ipython/ipykernel#1248 (it needs a new release).

@pllim pllim mentioned this pull request Oct 11, 2024
Merged
@rosteen rosteen modified the milestones: 4.0, 4.1 Oct 17, 2024
@pllim
Copy link
Contributor Author

pllim commented Oct 22, 2024 •
edited
Loading

ipykernel finally has a pre-prelease but it broke solara (and our RC testing workflow):

@pllim
Copy link
Contributor Author

pllim commented Oct 22, 2024

devdeps breakage still held up by unmerged PR:

@pllim
TST: devdeps to use Python 3.13
33e4f38 
EXP: What about stable job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosteen rosteen Awaiting requested review from rosteen rosteen will be requested when the pull request is marked ready for review rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh will be requested when the pull request is marked ready for review javerbukh is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry will be requested when the pull request is marked ready for review kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 will be requested when the pull request is marked ready for review bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay will be requested when the pull request is marked ready for review haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 will be requested when the pull request is marked ready for review cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen will be requested when the pull request is marked ready for review gibsongreen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Python 3.13 support
2 participants
@pllim @rosteen