Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rcal-969 Updates to add and use skycell coord info in asn header #1583

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

rcal-969 Updates to add and use skycell coord info in asn header #1583

wants to merge 4 commits into from

Conversation

ddavis-stsci
Copy link
Collaborator

Resolves RCAL-969

Closes #1560

This PR adds additional info to the asn header keyword skycell_wcs_info and updates the mosaic pipeline to use
that information to construct the skycell data from the input exposures.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • [N/A] Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • [N/A] Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst
The passing regression tests are at https://github.com/spacetelescope/RegressionTests/actions/runs/12790479162

@ddavis-stsci ddavis-stsci added this to the 25Q2_B17 milestone Jan 15, 2025
@ddavis-stsci ddavis-stsci self-assigned this Jan 15, 2025
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner January 15, 2025 15:33
@github-actions github-actions bot added documentation Improvements or additions to documentation Wide Field Instrument (WFI) labels Jan 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.93%. Comparing base (f538ba0) to head (af87194).

Files with missing lines Patch % Lines
romancal/pipeline/mosaic_pipeline.py 12.50% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
- Coverage   77.94%   77.93%   -0.01%     
==========================================
  Files         115      115              
  Lines        7622     7624       +2     
==========================================
+ Hits         5941     5942       +1     
- Misses       1681     1682       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stscieisenhamer stscieisenhamer Awaiting requested review from stscieisenhamer

At least 1 approving review is required to merge this pull request.

Assignees

@ddavis-stsci ddavis-stsci

Labels
associations documentation Improvements or additions to documentation mosaic pipeline Wide Field Instrument (WFI)
Projects
None yet
Milestone
25Q2_B17
Development

Successfully merging this pull request may close these issues.

Update coord in skycell associations
1 participant
@ddavis-stsci