Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skycell_asn generated associations are not validated against the association schema #1590

Closed
stscijgbot-rstdms opened this issue Jan 27, 2025 · 2 comments · Fixed by #1592
Closed

Comments

@stscijgbot-rstdms
Copy link
Collaborator

Issue RCAL-993 was created on JIRA by Brett Graham:

skycell_asn directly writes to a json file:

with open(asn_file_name + "_asn.json", "w") as outfile:

without validating the contents against the asn schema:

https://github.com/spacetelescope/romancal/blob/262df9af14fd09264fa9670395e2bb17c20b49a2/romancal/associations/lib/asn_schema_jw_level3.json

This results in no validation of skycell_asn generated asn contents.

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Brett Graham on JIRA:

Looking into this a bit more it looks like the schema is used and the apparent lack of validation is due to schema errors where properties are defined on a string object.

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Nadia Dencheva on JIRA:

#1592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant