feat(fe2): Create/Join Workspace as part of signup flow #3997
Conversation
andrewwallacespeckle
changed the title
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
After I verify my email, I get the "verify additional email" screen (even with a new account), but something gets stuck in a loop until it just crashed everything. Is this only on my machine? I cant repro this on another branch 🤔 
Screen.Recording.2025-02-21.at.20.47.19.mov |
…/specklesystems/speckle-server into andrew/everything-is-a-workspace
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
packages/frontend-2/components/workspace/DiscoverableWorkspaces.vue
Outdated
Show resolved
Hide resolved
packages/frontend-2/components/workspace/DiscoverableWorkspaces.vue
Outdated
Show resolved
Hide resolved
| }) | ||
|
|
||
| const allWorkspaces = computed(() => { | ||
| const requested = ( |
There was a problem hiding this comment.
Is there a reason why items in and status: request.status is needed? Could be something like this:
const allWorkspaces = computed(() => [
...workspaceJoinRequests.value.items.map(request => ({ ...request.workspace })),
...discoverableWorkspaces.value.map(workspace => ({ ...workspace, status: 'Request to join' }))
])
Also not sure about using 'Request to join' as a status, I guess because you render the status in the button but I wouldn't mix them as its not really a status
There was a problem hiding this comment.
The request.status is needed because DiscoverableList_Requests returns workspace data nested under a request object with status, but DiscoverableList_Discoverable returns workspace data directly, so we need to preserve the status when combining them. Does that make sense or maybe I'm misunderstanding?
I fixed the second part
packages/frontend-2/components/workspace/wizard/step/Region.vue
Outdated
Show resolved
Hide resolved
packages/frontend-2/components/workspace/wizard/step/Region.vue
Outdated
Show resolved
Hide resolved
packages/frontend-2/lib/workspaces/composables/discoverableWorkspaces.ts
Outdated
Show resolved
Hide resolved
You will need the following frontend feature flags:
FF_WORKSPACES_NEW_PLANS_ENABLED=true
FF_FORCE_WORKSPACE_MEMBERSHIP=true