Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fe2): Create/Join Workspace as part of signup flow #3997
base: main
Are you sure you want to change the base?
feat(fe2): Create/Join Workspace as part of signup flow #3997
Changes from 40 commits
b2305e3
b6a3409
c83be11
39ab666
c5246ad
67c0bb7
122799f
35af53c
58ddf4f
6267d28
ffbd862
48f203a
f4d9265
baab45a
322a4e5
d5712f4
c2f00b9
b4dafc1
955587e
d39e8a6
1f615ef
bc41840
239064f
8cf18ae
6191c37
be41269
58974bc
dbc3a6d
de2a38d
21e4319
cb35b38
a0e1b12
313f2ed
c9dae87
5645178
1287a92
4613521
71d82ba
96f2e0c
34acb42
3cc5bc0
1935225
eadb23e
139d687
4f93b6c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why
items in
andstatus: request.status
is needed? Could be something like this:Also not sure about using 'Request to join' as a status, I guess because you render the status in the button but I wouldn't mix them as its not really a status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
request.status
is needed becauseDiscoverableList_Requests
returns workspace data nested under a request object with status, butDiscoverableList_Discoverable
returns workspace data directly, so we need to preserve the status when combining them. Does that make sense or maybe I'm misunderstanding?I fixed the second part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also show in the existing create a workspace wizard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the composable so it will check for the FF and remove SSO if its false.